From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panfrost: Add GPU_PM_RT support for RZ/G3L SoC
Date: Thu, 05 Mar 2026 13:22:27 +1000 [thread overview]
Message-ID: <review-patch4-20260304134845.267030-5-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260304134845.267030-5-biju.das.jz@bp.renesas.com>
Patch Review
This patch adds a single compatible entry `renesas,r9a08g046-mali` pointing to `default_pm_rt_data`.
**Looks correct.** The placement is alphabetically ordered next to the existing `r9a09g047` entry. The `default_pm_rt_data` provides `GPU_PM_RT` which ensures the reset assert/deassert and clock enable/disable happen during runtime suspend/resume, matching the cover letter's description.
**Minor: The commit message says "RZ/G3L SoC" but doesn't mention which GPU it has.** The cover letter states it's a Mali-G31, and this is a bifrost driver entry, so it's fine, but the commit message could be slightly more descriptive.
---
**Summary of required changes:**
1. **Patch 3**: Remove the duplicate `err = PTR_ERR(pfdev->bus_ace_clock)` assignment — this is a clear copy-paste bug.
**Optional improvements:**
- **Patch 3**: Harmonize the `bus_clock` init code with the `bus_ace_clock` init code (either both guarded or both unguarded for `clk_prepare_enable`).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-05 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 13:48 [PATCH 0/4] Add RZ/G3L GFX support Biju
2026-03-04 13:48 ` [PATCH 1/4] dt-bindings: gpu: mali-bifrost: Add compatible for RZ/G3L SoC Biju
2026-03-05 3:22 ` Claude review: " Claude Code Review Bot
2026-03-04 13:48 ` [PATCH 2/4] drm/panfrost: Drop redundant optional clock checks in runtime PM Biju
2026-03-05 3:22 ` Claude review: " Claude Code Review Bot
2026-03-04 13:48 ` [PATCH 3/4] drm/panfrost: Add bus_ace optional clock support for RZ/G2L Biju
2026-03-05 3:22 ` Claude review: " Claude Code Review Bot
2026-03-04 13:48 ` [PATCH 4/4] drm/panfrost: Add GPU_PM_RT support for RZ/G3L SoC Biju
2026-03-05 3:22 ` Claude Code Review Bot [this message]
2026-03-05 3:22 ` Claude review: Add RZ/G3L GFX support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-20 16:41 [PATCH v2 0/4] " Biju
2026-03-20 16:41 ` [PATCH v2 4/4] drm/panfrost: Add GPU_PM_RT support for RZ/G3L SoC Biju
2026-03-21 17:29 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260304134845.267030-5-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox