From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add checking oversized commands Date: Mon, 09 Mar 2026 09:11:26 +1000 Message-ID: In-Reply-To: <20260306-cmdq-continuation-v6-4-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> <20260306-cmdq-continuation-v6-4-cc7b629200ee@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds a size check at the top of `allocate_command` to reject commands large= r than `GSP_MSG_QUEUE_ELEMENT_SIZE_MAX` (65536 bytes) with `EMSGSIZE`. Also= adds the `GSP_MSG_QUEUE_ELEMENT_SIZE_MAX` constant from bindings. This is a defensive check =E2=80=94 after patch 8, `send_command` will spli= t large commands so they never hit this check, but it protects `send_single= _command` (and documents the constraint) clearly. No issues. --- Generated by Claude Code Patch Reviewer