public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: pci: check if VGA decoding was really activated
Date: Mon, 09 Mar 2026 08:05:36 +1000	[thread overview]
Message-ID: <review-patch4-20260307173538.763188-5-Simon.Richter@hogyros.de> (raw)
In-Reply-To: <20260307173538.763188-5-Simon.Richter@hogyros.de>

Patch Review

**Verdict: Has a coding style issue.**

This is the core functional change — reading back `PCI_BRIDGE_CONTROL` after writing to verify the bridge actually accepted the VGA enable. The logic is correct: only check on `decode == true` (enabling), since failure to disable is less critical.

**Coding style bug** at `drivers/pci/pci.c:6203`:

```c
if(!(cmd & PCI_BRIDGE_CTL_VGA))
```

Missing space between `if` and `(`. Kernel coding style requires `if (condition)`. This should be `if (!(cmd & PCI_BRIDGE_CTL_VGA))`.

The choice of `-EIO` as the error code is reasonable for a hardware communication issue.

One consideration: if there are multiple bridges in the hierarchy and an intermediate one fails, the bridges already configured earlier in the `while (bus)` loop will have `PCI_BRIDGE_CTL_VGA` set but the function returns `-EIO`. The caller (`__vga_tryget`) will propagate the error without undoing those earlier bridge writes. This is similar to the state-consistency concern from patch 2 and is probably acceptable in practice, but worth noting.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 22:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 17:35 [PATCH v3 0/5] Bridges without VGA support Simon Richter
2026-03-07 17:35 ` [PATCH v3 1/5] vgaarb: pass vga_get_uninterruptible() errors to userspace Simon Richter
2026-03-08 22:05   ` Claude review: " Claude Code Review Bot
2026-03-07 17:35 ` [PATCH v3 2/5] vgaarb: pass errors from pci_set_vga_state() up Simon Richter
2026-03-08 22:05   ` Claude review: " Claude Code Review Bot
2026-03-07 17:35 ` [PATCH v3 3/5] vgaarb: mark vga_get() and wrappers as __must_check Simon Richter
2026-03-08 22:05   ` Claude review: " Claude Code Review Bot
2026-03-07 17:35 ` [PATCH v3 4/5] pci: check if VGA decoding was really activated Simon Richter
2026-03-08 22:05   ` Claude Code Review Bot [this message]
2026-03-07 17:35 ` [PATCH v3 5/5] pci: mark pci_set_vga_state() as __must_check Simon Richter
2026-03-08 22:05   ` Claude review: " Claude Code Review Bot
2026-03-08 22:05 ` Claude review: Bridges without VGA support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-17 17:04 [PATCH 0/5] bridges " Simon Richter
2026-02-17 17:04 ` [PATCH 4/5] pci: check if VGA decoding was really activated Simon Richter
2026-02-17 20:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260307173538.763188-5-Simon.Richter@hogyros.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox