From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_dp: Simplify error handling Date: Tue, 10 Mar 2026 11:47:01 +1000 Message-ID: In-Reply-To: <20260310-drm-rk-fixes-v2-4-645ecfb43f49@collabora.com> References: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> <20260310-drm-rk-fixes-v2-4-645ecfb43f49@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Good, minor note** Removes superfluous `ret =3D PTR_ERR(...); return ret;` patterns in favor o= f direct `return PTR_ERR(...)`. Also propagates the return value of `drm_co= nnector_attach_encoder()`: ```c - drm_connector_attach_encoder(connector, encoder); - return 0; + return drm_connector_attach_encoder(connector, encoder); ``` This is correct =E2=80=94 `drm_connector_attach_encoder()` can return an er= ror, and the old code silently ignored it. The `dev` variable removal in `d= w_dp_probe()` is a trivial cleanup. --- Generated by Claude Code Patch Reviewer