From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Centralize firmware image table selection at probe time Date: Wed, 11 Mar 2026 13:35:22 +1000 Message-ID: In-Reply-To: <20260310-sahara_protocol_new_v2-v3-4-994ea4b0d5ad@oss.qualcomm.com> References: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> <20260310-sahara_protocol_new_v2-v3-4-994ea4b0d5ad@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `struct sahara_variant` and `sahara_select_variant()` to replace ad-hoc conditionals. **Issues:** - **Regression for unknown controllers:** The old code defaulted to AIC100 for any unrecognized controller name. The new code returns `-ENODEV` from `sahara_select_variant()` if no variant matches. This means if a new AIC device appears that doesn't match any variant string, it will fail to probe instead of falling back. This is a behavioral change that should be explicitly called out. - `sahara_select_variant` uses `int i` for the loop counter iterating over `ARRAY_SIZE()`. Using `unsigned int` or `size_t` would be more appropriate. --- Generated by Claude Code Patch Reviewer