public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sdm670-google: add common device tree include
Date: Tue, 10 Mar 2026 11:42:23 +1000	[thread overview]
Message-ID: <review-patch4-20260310002606.16413-5-mailingradian@gmail.com> (raw)
In-Reply-To: <20260310002606.16413-5-mailingradian@gmail.com>

Patch Review

**Status: Good refactoring, one concern.**

The factoring approach is correct. The common dtsi removes device-specific properties (`model`, `compatible`, `charge-full-design-microamp-hours`, `height`, `touchscreen-x-mm`, `touchscreen-y-mm`, and panel `compatible`) and adds labels (`framebuffer:`, `fb_mem:`, `panel:`, `rmi4_f12:`) for overriding in device-specific files.

1. **Framebuffer `height` comment**: The common dtsi replaces the `height` property with a comment:
   ```
   +			/* height is in specific device trees */
   ```
   This is fine for documentation, but it means the common framebuffer node lacks a required `height` property for `simple-framebuffer`. If used standalone (which it isn't, as a `.dtsi`), this would be invalid. This is acceptable since the `.dtsi` is always included by a `.dts` that provides `height`, but the DT compiler may not warn if a `.dts` forgets to set it.

2. **Memory-region change**: The framebuffer changes from `reg` to `memory-region`:
   ```
   -			reg = <0 0x9c000000 0 (1080 * 2220 * 4)>;
   +			memory-region = <&fb_mem>;
   ```
   This is a good change since it references the reserved memory region properly, but it changes the binding usage for the existing sargo board. The `fb_mem` region is `0x2400000` bytes (about 37.7 MB) which is larger than `1080 * 2220 * 4 = 9,590,400` bytes. This should still work since `simple-framebuffer` only reads the needed portion, but the semantics are slightly different.

3. **License change**: The SPDX change from `GPL-2.0` to `GPL-2.0-only` is well-explained in the commit message.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-10  1:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  0:26 [PATCH v3 0/5] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-03-10  0:26 ` [PATCH v3 1/5] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  0:26 ` [PATCH v3 2/5] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  0:26 ` [PATCH v3 3/5] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  0:26 ` [PATCH v3 4/5] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-03-10  1:42   ` Claude Code Review Bot [this message]
2026-03-10  0:26 ` [PATCH v3 5/5] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  1:42 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-17  0:08 [PATCH v2 0/6] " Richard Acayan
2026-02-17  0:08 ` [PATCH v2 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-17  5:51   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:32 ` [PATCH 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260310002606.16413-5-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox