From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/hdmi: Consistently use u32 instead of uint32_t
Date: Thu, 12 Mar 2026 06:45:27 +1000 [thread overview]
Message-ID: <review-patch4-20260311-drm-msm-hdmi-cleanup-v1-4-c5535245f6de@oss.qualcomm.com> (raw)
In-Reply-To: <20260311-drm-msm-hdmi-cleanup-v1-4-c5535245f6de@oss.qualcomm.com>
Patch Review
Standard kernel coding style cleanup. The changes are mechanical `uint32_t` → `u32` replacements across hdmi.c, hdmi_audio.c, hdmi_bridge.c, hdmi_hpd.c, and hdmi_i2c.c.
One minor note: in `hdmi_audio.c`, two separate declaration lines are merged into one:
```c
- uint32_t acr_pkt_ctrl, vbi_pkt_ctrl, aud_pkt_ctrl;
- uint32_t audio_config;
+ u32 acr_pkt_ctrl, vbi_pkt_ctrl, aud_pkt_ctrl, audio_config;
```
This is fine but slightly beyond the stated scope of "type changes only." Not a problem.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 20:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 20:17 [PATCH 0/7] drm/msm/hdmi: Simplify the code Krzysztof Kozlowski
2026-03-11 20:17 ` [PATCH 1/7] drm/msm/hdmi: Simplify with dev_of_node() Krzysztof Kozlowski
2026-03-11 20:45 ` Claude review: " Claude Code Review Bot
2026-03-11 20:17 ` [PATCH 2/7] drm/msm/hdmi: Avoid double error print on msm_hdmi_get_phy() failure Krzysztof Kozlowski
2026-03-11 20:45 ` Claude review: " Claude Code Review Bot
2026-03-11 20:17 ` [PATCH 3/7] drm/msm/hdmi: Simplify with local 'dev' variable Krzysztof Kozlowski
2026-03-11 20:45 ` Claude review: " Claude Code Review Bot
2026-03-11 20:17 ` [PATCH 4/7] drm/msm/hdmi: Consistently use u32 instead of uint32_t Krzysztof Kozlowski
2026-03-11 20:45 ` Claude Code Review Bot [this message]
2026-03-11 20:17 ` [PATCH 5/7] drm/msm/hdmi: Drop redundant 'int' for longs Krzysztof Kozlowski
2026-03-11 20:45 ` Claude review: " Claude Code Review Bot
2026-03-11 20:17 ` [PATCH 6/7] drm/msm/hdmi_bridge: Simplify register bit updates Krzysztof Kozlowski
2026-03-11 20:45 ` Claude review: " Claude Code Review Bot
2026-03-11 20:17 ` [PATCH 7/7] drm/msm/hdmi_hdcp: " Krzysztof Kozlowski
2026-03-11 20:45 ` Claude review: " Claude Code Review Bot
2026-03-11 20:45 ` Claude review: drm/msm/hdmi: Simplify the code Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260311-drm-msm-hdmi-cleanup-v1-4-c5535245f6de@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox