From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: Trust the SSoT UBWC config Date: Thu, 12 Mar 2026 07:21:53 +1000 Message-ID: In-Reply-To: <20260311-ubwc-rework-v2-4-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> <20260311-ubwc-rework-v2-4-69f718f2a1c9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review >From Konrad Dybcio. Removes the local copy (`_ubwc_config`) and per-GPU hardcoded overrides in `a6xx_calc_ubwc_config()`, trusting the central UBWC config database entirely. This is a large behavioral change - all the GPU-specific `highest_bank_bit` and `ubwc_swizzle` overrides are dropped. The `DRM_WARN_ONCE` diagnostics for mismatches are also removed. This requires that the central UBWC database has correct values for all SoCs. The patch has appropriate `Reviewed-by` tags. ### PATCHES 5-14: Use new helpers These are mechanical patches replacing direct struct field access with helper function calls (`qcom_ubwc_version_tag()`, `qcom_ubwc_min_acc_length_64b()`, `qcom_ubwc_macrotile_mode()`, `qcom_ubwc_bank_spread()`, `qcom_ubwc_swizzle()`). All look correct and are well-reviewed. --- Generated by Claude Code Patch Reviewer