From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/dp: Add DPCD for configuring AS SDP for PR + VRR Date: Thu, 12 Mar 2026 06:55:28 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-5-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-5-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `PANEL_REPLAY_CONFIG3` at DPCD address `0x11a` with AS SDP setup time fields. **Concern:** The `DP_PR_AS_SDP_SETUP_TIME()` macro uses a custom shift+mask pattern rather than the more idiomatic `FIELD_PREP()`: ```c # define DP_PR_AS_SDP_SETUP_TIME(t) (((t) << DP_PR_AS_SDP_SETUP_TIME_SHIFT) & \ DP_PR_AS_SDP_SETUP_TIME_MASK) ``` Consider using `FIELD_PREP(DP_PR_AS_SDP_SETUP_TIME_MASK, t)` for consistency with modern kernel style, though the existing approach works correctly. --- Generated by Claude Code Patch Reviewer