From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: add helper controlling AMSBC enablement Date: Fri, 13 Mar 2026 14:12:49 +1000 Message-ID: In-Reply-To: <20260312-ubwc-rework-v3-4-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-4-b7e8f800176a@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review `qcom_ubwc_enable_amsbc()` returns `true` for `>= UBWC_3_0`, including UBWC 6.0. The a8xx driver (`a8xx_gpu.c:278`) correctly guards with `if (ubwc_version < UBWC_6_0)` since UBWC 6.0 uses `yuvnotcomptofc` instead. This caller-side exception is fine but a comment in the helper noting UBWC 6.0's different behavior could be useful. --- Generated by Claude Code Patch Reviewer