public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC
Date: Sat, 14 Mar 2026 07:07:32 +1000	[thread overview]
Message-ID: <review-patch4-20260313120814.1312410-5-sibi.sankar@oss.qualcomm.com> (raw)
In-Reply-To: <20260313120814.1312410-5-sibi.sankar@oss.qualcomm.com>

Patch Review

This is the main DTS patch adding 286 lines to `glymur.dtsi`. Key observations:

**ADSP node** (`remoteproc@6800000`):
- Compatible: `"qcom,glymur-adsp-pas", "qcom,sm8550-adsp-pas"` — matches binding.
- 6 interrupts including "shutdown-ack" — matches the binding's maxItems: 6 conditional.
- Power domains: `lcx`, `lmx` — matches the sm8550-adsp-pas power domain constraint.
- IOMMU: `<&apps_smmu 0x1000 0x0>` — optional per cover letter, present here.
- Fastrpc compute CBs 3-8 with dual IOMMU entries and `dma-coherent` — consistent pattern.
- CB 7 has three IOMMU entries with different masks (`0x40`, `0x0`, `0x0`) versus the other CBs (`0x80`, `0x20`) — this is likely intentional as a secure/non-secure split.

**CDSP node** (`remoteproc@32300000`):
- Compatible: `"qcom,glymur-cdsp-pas", "qcom,sm8550-cdsp-pas"` — matches binding.
- 6 interrupts including "shutdown-ack" — matches binding.
- Power domains: `cx`, `mxc`, `nsp` (3 domains) — matches the sm8550-cdsp-pas constraint.
- Fastrpc compute CBs 1-8, 10-12 with CB 9 documented as secure:
```c
					/* note: compute-cb@9 is secure */
```
- The SID gap from 0x2408 (CB 8) to 0x240c (CB 10) accounts for 3 secure CBs in the SID space (0x2409–0x240b), which is a standard Qualcomm CDSP IOMMU layout.

Both nodes have `status = "disabled"` as expected for SoC-level dtsi.

No issues. Reviewed-by from both Abel Vesa and Konrad Dybcio.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 12:08 [PATCH V5 0/5] Enable ADSP and CDSP for Glymur SoC Sibi Sankar
2026-03-13 12:08 ` [PATCH V5 1/5] dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur ADSP Sibi Sankar
2026-03-13 21:07   ` Claude review: " Claude Code Review Bot
2026-03-13 12:08 ` [PATCH V5 2/5] dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur CDSP Sibi Sankar
2026-03-13 21:07   ` Claude review: " Claude Code Review Bot
2026-03-13 12:08 ` [PATCH V5 3/5] dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur Sibi Sankar
2026-03-13 21:07   ` Claude review: " Claude Code Review Bot
2026-03-13 12:08 ` [PATCH V5 4/5] arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC Sibi Sankar
2026-03-13 21:07   ` Claude Code Review Bot [this message]
2026-03-13 12:08 ` [PATCH V5 5/5] arm64: dts: qcom: glymur-crd: Enable ADSP and CDSP Sibi Sankar
2026-03-13 21:07   ` Claude review: " Claude Code Review Bot
2026-03-13 21:07 ` Claude review: Enable ADSP and CDSP for Glymur SoC Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  3:36 [PATCH V4 0/5] " Sibi Sankar
2026-03-10  3:36 ` [PATCH V4 4/5] arm64: dts: qcom: glymur: Add " Sibi Sankar
2026-03-11  3:43   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260313120814.1312410-5-sibi.sankar@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox