From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC Date: Sat, 14 Mar 2026 07:07:32 +1000 Message-ID: In-Reply-To: <20260313120814.1312410-5-sibi.sankar@oss.qualcomm.com> References: <20260313120814.1312410-1-sibi.sankar@oss.qualcomm.com> <20260313120814.1312410-5-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the main DTS patch adding 286 lines to `glymur.dtsi`. Key observati= ons: **ADSP node** (`remoteproc@6800000`): - Compatible: `"qcom,glymur-adsp-pas", "qcom,sm8550-adsp-pas"` =E2=80=94 ma= tches binding. - 6 interrupts including "shutdown-ack" =E2=80=94 matches the binding's max= Items: 6 conditional. - Power domains: `lcx`, `lmx` =E2=80=94 matches the sm8550-adsp-pas power d= omain constraint. - IOMMU: `<&apps_smmu 0x1000 0x0>` =E2=80=94 optional per cover letter, pre= sent here. - Fastrpc compute CBs 3-8 with dual IOMMU entries and `dma-coherent` =E2=80= =94 consistent pattern. - CB 7 has three IOMMU entries with different masks (`0x40`, `0x0`, `0x0`) = versus the other CBs (`0x80`, `0x20`) =E2=80=94 this is likely intentional = as a secure/non-secure split. **CDSP node** (`remoteproc@32300000`): - Compatible: `"qcom,glymur-cdsp-pas", "qcom,sm8550-cdsp-pas"` =E2=80=94 ma= tches binding. - 6 interrupts including "shutdown-ack" =E2=80=94 matches binding. - Power domains: `cx`, `mxc`, `nsp` (3 domains) =E2=80=94 matches the sm855= 0-cdsp-pas constraint. - Fastrpc compute CBs 1-8, 10-12 with CB 9 documented as secure: ```c /* note: compute-cb@9 is secure */ ``` - The SID gap from 0x2408 (CB 8) to 0x240c (CB 10) accounts for 3 secure CB= s in the SID space (0x2409=E2=80=930x240b), which is a standard Qualcomm CD= SP IOMMU layout. Both nodes have `status =3D "disabled"` as expected for SoC-level dtsi. No issues. Reviewed-by from both Abel Vesa and Konrad Dybcio. --- Generated by Claude Code Patch Reviewer