From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpuvm: Add a helper to check if two VA can be merged Date: Sat, 14 Mar 2026 06:48:45 +1000 Message-ID: In-Reply-To: <20260313150956.1618635-5-adrian.larumbe@collabora.com> References: <20260313150956.1618635-1-adrian.larumbe@collabora.com> <20260313150956.1618635-5-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The `can_merge()` helper consolidates scattered merge checks into one function. The logic looks correct: - Same GEM object required, must be non-NULL - VAs must be contiguous/overlapping (WARN_ON if gap) - VA diff must match GEM offset diff for merge eligibility One minor style note: the comment style uses `/* ... */` block comments which is fine but inconsistent -- some start with `/*` on the same line as text. Kernel style typically has `/*` on its own line for multi-line comments. The removal of the inline merge checks in `__drm_gpuvm_sm_map()` is clean and the replacement with `can_merge(gpuvm, va, &req->map)` is correct. --- Generated by Claude Code Patch Reviewer