From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: Move link training to atomic_enable() Date: Mon, 16 Mar 2026 12:12:56 +1000 Message-ID: In-Reply-To: <20260314-hpd-refactor-v5-4-0c8450737d64@oss.qualcomm.com> References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> <20260314-hpd-refactor-v5-4-0c8450737d64@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Moves `msm_dp_ctrl_on_link()` from `msm_dp_display_process_hpd_high()` to `= msm_dp_bridge_atomic_enable()`. **Issues:** 1. The `// TODO: schedule drm_connector_set_link_status_property()` comment= should be addressed or at least converted to a proper C-style comment: ```c + // TODO: schedule drm_connector_set_link_status_property() ``` The kernel coding style requires `/* */` comments. Also, if link training f= ails, the function continues into `msm_dp_display_enable()` anyway, which s= eems wrong =E2=80=94 a failed link train should probably bail out. 2. The commit message says it also changes hpd_notify() behavior ("call the= plug/unplug handlers directly in hpd_notify() instead of queueing them"), = but there's no change to hpd_notify() in this patch. The description seems = to be a leftover from an earlier version. --- Generated by Claude Code Patch Reviewer