From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd: fix force_yuv420/422_output being ignored
Date: Mon, 16 Mar 2026 11:48:52 +1000 [thread overview]
Message-ID: <review-patch4-20260315223307.45807-5-johanneswueller@gmail.com> (raw)
In-Reply-To: <20260315223307.45807-5-johanneswueller@gmail.com>
Patch Review
**Correctness concern:** The original code gated `force_yuv420_output` on `drm_mode_is_420_also()` and `force_yuv422_output` on `DRM_COLOR_FORMAT_YCBCR422`. These guards existed to prevent forcing a pixel encoding the display genuinely cannot accept. Removing them means:
```c
else if (aconnector && aconnector->force_yuv420_output)
timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
```
This will now force YCbCr 4:2:0 even for modes that are not 420-capable at all (not just "420_also" but completely 420-incompatible). This could cause a black screen or signal errors on displays that truly don't support 4:2:0 for a given mode.
The commit message frames this as "the flag becomes ineffective" when the display doesn't advertise the capability, but the `force_` prefix in the debugfs attribute does suggest "force regardless." Still, this is a user-facing behavior change that removes safety checks. It would be better to either:
1. Gate on `edid_overridden` (only bypass the check when an override is active), or
2. Add a warning log when forcing an unadvertised encoding so users can diagnose issues.
**Interaction with Patch 2:** This patch is listed as fixing issues with EDID overrides, but it unconditionally changes behavior for all displays, not just those with overrides. This seems like an overly broad change for the stated problem.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-16 1:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 22:33 [PATCH 0/4] drm/amd: fix HDMI output with non-HDMI EDID overrides Johannes Wüller
2026-03-15 22:33 ` [PATCH 1/4] drm: add edid_overridden flag to drm_connector Johannes Wüller
2026-03-16 1:48 ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 2/4] drm/amd: fix HDMI signal type for EDID overrides Johannes Wüller
2026-03-16 1:48 ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 3/4] drm/amd: treat max_tmds_clock==0 as unconstrained Johannes Wüller
2026-03-16 1:48 ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 4/4] drm/amd: fix force_yuv420/422_output being ignored Johannes Wüller
2026-03-16 1:48 ` Claude Code Review Bot [this message]
2026-03-16 1:48 ` Claude review: drm/amd: fix HDMI output with non-HDMI EDID overrides Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260315223307.45807-5-johanneswueller@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox