From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Centralize firmware image table selection at probe time Date: Sun, 22 Mar 2026 04:44:34 +1000 Message-ID: In-Reply-To: <20260319-sahara_protocol_new_v2-v4-4-47ad79308762@oss.qualcomm.com> References: <20260319-sahara_protocol_new_v2-v4-0-47ad79308762@oss.qualcomm.com> <20260319-sahara_protocol_new_v2-v4-4-47ad79308762@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Refactors firmware table selection into a data-driven `sahara_variants[]` t= able. **Issues:** - **Behavioral change**: Previously, unknown devices fell through to AIC100= defaults. Now `sahara_select_variant()` returns `NULL` =E2=86=92 `-ENODEV`= . If any MHI controller name other than literal "AIC100" or "AIC200" was pr= eviously used, this is a regression. - **No trailing comma** on the last `sahara_variants[]` entry =E2=80=94 min= or style nit but standard kernel practice. --- Generated by Claude Code Patch Reviewer