From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay to 1 msec
Date: Sun, 22 Mar 2026 04:12:40 +1000 [thread overview]
Message-ID: <review-patch4-20260319164833.409126-5-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260319164833.409126-5-biju.das.jz@bp.renesas.com>
Patch Review
Changes the delay after CMN_RSTB deassert from `udelay(1)` (1 usec) to `fsleep(1000)` (1 msec), matching the hardware manual's >= 1 msec requirement.
```c
- udelay(1);
+ fsleep(1000);
```
This is a clear fix — `udelay(1)` is 1 microsecond, three orders of magnitude less than the required 1 millisecond. Using `fsleep()` is the correct API choice here: for a 1ms delay, `fsleep` will use `usleep_range()` internally, which is appropriate for non-atomic context (this runs from `atomic_pre_enable` bridge callback, which is a process context despite the "atomic" name).
**Missing Fixes tag:** This patch fixes a real hardware timing violation (1 usec vs required 1 msec) and could reasonably carry a `Fixes:` tag pointing to the original commit that introduced the `udelay(1)`. If the driver has been working despite this, it may be that the hardware is tolerant, but it's still out of spec.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 16:48 [PATCH v2 0/4] Improvements on RZ/G2L MIPI DSI driver Biju
2026-03-19 16:48 ` [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 2/4] drm: renesas: rzg2l_mipi_dsi: Fix assert of CMN_RSTB signal Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 3/4] drm: renesas: rzg2l_mipi_dsi: Fix deassert " Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 4/4] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay to 1 msec Biju
2026-03-21 18:12 ` Claude Code Review Bot [this message]
2026-03-21 18:12 ` Claude review: Improvements on RZ/G2L MIPI DSI driver Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260319164833.409126-5-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox