From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: drm: dispatch delayed work items to the private data Date: Wed, 25 Mar 2026 07:11:04 +1000 Message-ID: In-Reply-To: <20260323-aref-workitem-v3-4-f59729b812aa@collabora.com> References: <20260323-aref-workitem-v3-0-f59729b812aa@collabora.com> <20260323-aref-workitem-v3-4-f59729b812aa@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Another small patch adding `HasDelayedWork` for `Device`: ```rust unsafe impl HasDelayedWork, ID> for Device where T: drm::Driver, T::Data: HasDelayedWork, ID>, { } ``` `HasDelayedWork` is a marker trait (no methods) that inherits from `HasWork= `, so this is just declaring that the delayed work guarantee is satisfied. = Since it requires `T::Data: HasDelayedWork, ID>`, the guarantee f= lows from the driver's data type. Correct. **One note:** This patch adds the `HasDelayedWork` import but does not add = a corresponding `WorkItem` impl for the delayed case. This is fine because = the same `WorkItem` impl from Patch 2 covers both regular and delayed work = =E2=80=94 `RawDelayedWorkItem` just extends `RawWorkItem`, and the `WorkIte= mPointer::run` function is shared. Overall, this is a clean, well-reviewed series. No correctness issues found. --- Generated by Claude Code Patch Reviewer