From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors
Date: Wed, 25 Mar 2026 07:36:47 +1000 [thread overview]
Message-ID: <review-patch4-20260323-dw-hdmi-qp-scramb-v4-4-1d99df84883e@collabora.com> (raw)
In-Reply-To: <20260323-dw-hdmi-qp-scramb-v4-4-1d99df84883e@collabora.com>
Patch Review
**Overall: Clean and straightforward.**
- **IRQ registration moved after connector init:** The `devm_request_threaded_irq` is moved to after `drm_bridge_connector_init` and `drm_connector_attach_encoder`, which is correct — HPD interrupts could fire immediately and the handler needs `hdmi->connector` to be valid.
- **`hdmi->connector` set from `drm_bridge_connector_init`:** This is the bridge connector, not a user-allocated connector. Its lifetime is managed by DRM core, so storing it in `hdmi->connector` is fine as long as the driver doesn't outlive the DRM device.
- **Race on `hdmi->connector` in `dw_hdmi_qp_rk3588_hpd_work`:** The work function uses `hdmi->connector` (line 254) which is set during bind. Since the IRQ is now registered after connector init, this is safe. However, during unbind, if the work is still pending, it could access a freed connector. There's no `cancel_delayed_work_sync` in the unbind path for `hpd_work` — but this may be handled by `devm_request_threaded_irq` cleanup preventing new work from being scheduled, and the existing unbind sequence. Worth verifying that the unbind path is safe.
- **Minor: variable rename `irq` → `hpd_irq`:** Clean change to avoid confusion with other IRQs.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 17:45 [PATCH RESEND v4 0/4] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-03-23 17:45 ` [PATCH RESEND v4 1/4] drm/bridge: Add ->detect_ctx hook and drm_bridge_detect_ctx() Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 2/4] drm/bridge-connector: Switch to using ->detect_ctx hook Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 3/4] drm/bridge: dw-hdmi-qp: Add high TMDS clock ratio and scrambling support Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors Cristian Ciocaltea
2026-03-24 21:36 ` Claude Code Review Bot [this message]
2026-03-24 21:36 ` Claude review: Add HDMI 2.0 support to DW HDMI QP TX Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 1:38 [PATCH v4 0/4] " Cristian Ciocaltea
2026-03-03 1:38 ` [PATCH v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors Cristian Ciocaltea
2026-03-03 2:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260323-dw-hdmi-qp-scramb-v4-4-1d99df84883e@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox