From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC Date: Sun, 12 Apr 2026 13:46:55 +1000 Message-ID: In-Reply-To: <20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com> References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c + ret = qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); + if (ret) + return ret; + + pm_runtime_disable(&pdev->dev); + + return ret; ``` The approach of disabling runtime PM post-probe to prevent RPM request propagation from GMU's device links is reasonable. **Minor:** `return ret;` where `ret` is guaranteed to be 0 -- `return 0;` would be marginally clearer, though this is a style nit. **Concern: No cleanup path.** If the module is unbound/rebound, `pm_runtime_disable()` is called again on an already-disabled device. The PM core handles this gracefully (it's ref-counted via `disable_depth`), but repeated unload/reload could keep incrementing `disable_depth`. Since there's no `.remove` callback, there's no matching `pm_runtime_enable()`. This is probably fine in practice since this driver is essentially always-loaded, but worth noting. --- Generated by Claude Code Patch Reviewer