Claude review: drm/i915/color: Enable SDR plane color pipeline

Claude Code Review Bot
2026-04-12T03:07:22Z

Overall Series Review

Subject: drm/i915/color: Enable SDR plane color pipeline
Author: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Patches: 14
Reviewed: 2026-04-12T13:07:22.561946

---

This 13-patch series adds SDR plane color pipeline support to i915, building on the existing HDR plane color pipeline infrastructure and the DRM colorop framework. It introduces a new `DRM_COLOROP_FIXED_MATRIX` colorop type for fixed-function CSC blocks, adds pre/post-CSC LUT programming for SDR planes, and wires up YUV range correction through the colorop framework.

The series is generally well-structured with a clean patch decomposition (DRM core type, i915 pipeline wiring, HW programming, refactoring, new features). However, there is a **critical bug** in how the new colorop-based CSC/range-correction interacts with the existing legacy YUV color handling in `glk_plane_color_ctl()`, which will cause register corruption for YUV framebuffers on SDR planes and a regression for limited-range YUV content even without using color pipelines.

**Key issues:**
1. **Critical**: Conflicting CSC mode and YUV range correction programming paths in `glk_plane_color_ctl()` (Patches 3/12)
2. **Medium**: Hardcoded `plane - 3` offset for SDR plane register addressing (Patches 7/9)
3. **Minor**: Kernel-doc tag mismatch for `DRM_COLOROP_FM_YCBCR2020_FULL_RGB_NC` (Patch 1)
4. **Minor**: Post-CSC refactoring silently removes segment 0 programming (Patch 8)