From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/display: Add init_clock_gating.h stubs Date: Sun, 12 Apr 2026 12:04:48 +1000 Message-ID: In-Reply-To: <20260408233458.22666-5-ville.syrjala@linux.intel.com> References: <20260408233458.22666-1-ville.syrjala@linux.intel.com> <20260408233458.22666-5-ville.syrjala@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces the `#include "../../i915/intel_clock_gating.h"` with proper static inline stubs. This is needed because the next patch will add `intel_display_reset.c` to the xe build, and that file includes `intel_clock_gating.h`. Also removes the `#ifdef I915` guard from `intel_display_power.c` around the `intel_clock_gating_init()` call, which is now safe because xe has proper stubs. Clean and correct. Two functions are stubbed: `intel_clock_gating_init()` and `intel_clock_gating_hooks_init()`. Let me verify both are declared in the original header. The original xe compat header just included the i915 header which would pull in the real declarations. The new stubs provide empty implementations for xe. This is the right approach. **Looks good.** --- Generated by Claude Code Patch Reviewer