From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Switch to drmm_mode_config_init() and drop manual cleanup Date: Sun, 12 Apr 2026 10:51:24 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-4-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-4-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The approach is correct. Replacing `drm_mode_config_init()` with `drmm_mode_config_init()` and using `drmm_add_action_or_reset()` for `intel_atomic_global_obj_cleanup` is the right pattern. The devres LIFO ordering ensures `intel_atomic_global_obj_cleanup` runs before `drm_mode_config_cleanup`, preserving the original ordering. One concern: the removal of the `err_mode_config` label in `intel_display_driver_probe_nogem()` means that if `intel_crtc_init()` fails, no explicit cleanup is done -- it relies entirely on devres. This is correct *only if* all resources allocated between `intel_mode_config_init()` and `intel_crtc_init()` are also devres-managed. Worth verifying. --- Generated by Claude Code Patch Reviewer