public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Store IRQ register base iomem pointer in panthor_irq
Date: Sun, 12 Apr 2026 09:38:15 +1000	[thread overview]
Message-ID: <review-patch4-20260410164637.549145-5-karunika.choo@arm.com> (raw)
In-Reply-To: <20260410164637.549145-5-karunika.choo@arm.com>

Patch Review

**Issues found:**

1. **Bisection break**: The `panthor_pwr.c` change introduces a reference to `GPU_CONTROL_BASE`:
   ```c
   err = panthor_request_pwr_irq(ptdev, &pwr->irq, irq,
                                 PWR_INTERRUPTS_MASK,
                                 GPU_CONTROL_BASE + PWR_CONTROL_BASE);
   ```
   But `GPU_CONTROL_BASE` is not defined until patch 5 (`panthor_gpu_regs.h`). This will break compilation at this commit.

   Fix: either define `GPU_CONTROL_BASE` earlier (in `panthor_hw_regs.h` or `panthor_gpu_regs.h` in patch 2), or use the literal `0x0 +` or just `PWR_CONTROL_BASE` here since `GPU_CONTROL_BASE` is 0.

2. **Generic INT_* defines in `panthor_device.h`**: The new defines:
   ```c
   #define INT_RAWSTAT 0x0
   #define INT_CLEAR   0x4
   #define INT_MASK    0x8
   #define INT_STAT    0xc
   ```
   These are very generic names that could collide with other headers. Consider prefixing them (e.g., `PANTHOR_INT_RAWSTAT`) or scoping them more tightly. In a large kernel tree, short generic macro names are a collision risk.

The core design -- storing `void __iomem *iomem` in `struct panthor_irq` and using generic offsets -- is a good approach. Removing the `__reg_prefix` template parameter from the `PANTHOR_IRQ_HANDLER` macro simplifies the instantiation sites.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-11 23:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 16:46 [PATCH 0/8] drm/panthor: Localize register access by component Karunika Choo
2026-04-10 16:46 ` [PATCH 1/8] drm/panthor: Pass an iomem pointer to GPU register access helpers Karunika Choo
2026-04-10 18:11   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 ` [PATCH 2/8] drm/panthor: Split register definitions by components Karunika Choo
2026-04-10 18:08   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 ` [PATCH 3/8] drm/panthor: Replace cross-component register accesses with helpers Karunika Choo
2026-04-10 17:55   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 ` [PATCH 4/8] drm/panthor: Store IRQ register base iomem pointer in panthor_irq Karunika Choo
2026-04-10 17:53   ` Boris Brezillon
2026-04-11 23:38   ` Claude Code Review Bot [this message]
2026-04-10 16:46 ` [PATCH 5/8] drm/panthor: Use a local iomem base for GPU registers Karunika Choo
2026-04-10 18:11   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 ` [PATCH 6/8] drm/panthor: Use a local iomem base for PWR registers Karunika Choo
2026-04-10 18:12   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 ` [PATCH 7/8] drm/panthor: Use a local iomem base for firmware control registers Karunika Choo
2026-04-10 18:12   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-10 16:46 ` [PATCH 8/8] drm/panthor: Use a local iomem base for MMU AS registers Karunika Choo
2026-04-10 18:13   ` Boris Brezillon
2026-04-11 23:38   ` Claude review: " Claude Code Review Bot
2026-04-11 23:38 ` Claude review: drm/panthor: Localize register access by component Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-12 14:29 [PATCH v2 0/8] " Karunika Choo
2026-04-12 14:29 ` [PATCH v2 4/8] drm/panthor: Store IRQ register base iomem pointer in panthor_irq Karunika Choo
2026-04-13  9:05   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260410164637.549145-5-karunika.choo@arm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox