public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/pagemap: Use dma-map IOVA alloc, link, and sync API for DRM pagemap
Date: Sun, 12 Apr 2026 09:24:52 +1000	[thread overview]
Message-ID: <review-patch4-20260410205929.3914474-5-matthew.brost@intel.com> (raw)
In-Reply-To: <20260410205929.3914474-5-matthew.brost@intel.com>

Patch Review

The `struct drm_pagemap_iova_state` wrapper is well-designed, combining `dma_iova_state` with a tracking `offset` that serves as the iterator for packing IOVA addresses contiguously.

The `try_alloc` flag pattern in `drm_pagemap_migrate_map_system_pages` (`drm_pagemap.c:348-355`) is better than Patch 1's `!i` approach -- it correctly handles leading NULL pages by triggering on the first valid page.

The alignment hint logic is reasonable:
```c
(npages - i) * PAGE_SIZE >= HPAGE_PMD_SIZE ? HPAGE_PMD_SIZE : 0
```
This passes an alignment hint only when there are enough remaining pages to benefit from huge page IOMMU mappings.

The unmap path in `drm_pagemap_migrate_unmap_pages` (`drm_pagemap.c:413-416`) correctly does an early return after `dma_iova_destroy` when IOVA is active. This is safe because this function is only called from paths that map system pages (not device-private pages), so the loop below for device pages is not needed.

The `state` re-initialization in `drm_pagemap_evict_to_ram` on retry (`drm_pagemap.c:1189`) is correct and necessary.

No issues beyond what's noted above.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-11 23:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 20:59 [PATCH v7 0/5] Use new dma-map IOVA alloc, link, and sync API in GPU SVM and DRM pagemap Matthew Brost
2026-04-10 20:59 ` [PATCH v7 1/5] drm/gpusvm: Use dma-map IOVA alloc, link, and sync API in GPU SVM Matthew Brost
2026-04-11 23:24   ` Claude review: " Claude Code Review Bot
2026-04-10 20:59 ` [PATCH v7 2/5] drm/pagemap: Drop source_peer_migrates flag and assume true Matthew Brost
2026-04-11 23:24   ` Claude review: " Claude Code Review Bot
2026-04-10 20:59 ` [PATCH v7 3/5] drm/pagemap: Split drm_pagemap_migrate_map_pages into device / system Matthew Brost
2026-04-11 23:24   ` Claude review: " Claude Code Review Bot
2026-04-10 20:59 ` [PATCH v7 4/5] drm/pagemap: Use dma-map IOVA alloc, link, and sync API for DRM pagemap Matthew Brost
2026-04-11 23:24   ` Claude Code Review Bot [this message]
2026-04-10 20:59 ` [PATCH v7 5/5] drm/pagemap: Fix drm_pagemap_migrate_unmap_pages kerneldoc Matthew Brost
2026-04-11 23:24   ` Claude review: " Claude Code Review Bot
2026-04-11 23:24 ` Claude review: Use new dma-map IOVA alloc, link, and sync API in GPU SVM and DRM pagemap Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-08 20:15 [PATCH v6 0/5] " Matthew Brost
2026-04-08 20:15 ` [PATCH v6 4/5] drm/pagemap: Use dma-map IOVA alloc, link, and sync API for " Matthew Brost
2026-04-12  2:09   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260410205929.3914474-5-matthew.brost@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox