From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: dp: handle the IRQ_HPD events reported by USB-C Date: Thu, 23 Apr 2026 09:32:09 +1000 Message-ID: In-Reply-To: <20260420-hpd-irq-events-v2-4-402ffe27e9e9@oss.qualcomm.com> References: <20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com> <20260420-hpd-irq-events-v2-4-402ffe27e9e9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is small and focused: ```c if (extra_status == DRM_CONNECTOR_DP_IRQ_HPD) msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); ``` **This looks correct.** The `EV_IRQ_HPD_INT` event is already handled by the MSM DP event loop, so this will trigger the existing IRQ_HPD processing (DPCD reads, link retraining, MST handling etc). One question: could an IRQ_HPD arrive simultaneously with a connect event? In that case, both `EV_HPD_PLUG_INT` and `EV_IRQ_HPD_INT` would be queued. This matches the behavior of the hardware HPD path (where both can fire independently), so it should be fine. --- Generated by Claude Code Patch Reviewer