From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Suppress intentional warning backtraces in scaling unit tests Date: Thu, 23 Apr 2026 09:52:27 +1000 Message-ID: In-Reply-To: <20260420-kunit_add_support-v7-4-e8bc6e0f70de@redhat.com> References: <20260420-kunit_add_support-v7-0-e8bc6e0f70de@redhat.com> <20260420-kunit_add_support-v7-4-e8bc6e0f70de@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Clean and correct application of the API** The suppression wraps the exact call that triggers warnings. The comments explaining why suppression is needed are appropriate, though perhaps a bit verbose for the CLAUDE.md "no comments" guidance (but that doesn't apply to kernel code conventions). **Suppression covers all parameterized cases, not just error cases** ```c + KUNIT_START_SUPPRESSED_WARNING(test); scaling_factor = drm_rect_calc_hscale(¶ms->src, ¶ms->dst, params->min_range, params->max_range); + KUNIT_END_SUPPRESSED_WARNING(test); ``` This suppresses warnings for ALL parameterized test cases, including those that don't trigger warnings. This is fine (the overhead is negligible and the alternative would be conditional suppression based on `expected_scaling_factor`), but worth noting that the warning count won't always equal 1 for all parameterized cases. --- Generated by Claude Code Patch Reviewer