From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: dp: handle the IRQ_HPD events reported by USB-C Date: Thu, 23 Apr 2026 09:07:43 +1000 Message-ID: In-Reply-To: <20260421-hpd-irq-events-v3-4-44d2bf40dfc2@oss.qualcomm.com> References: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> <20260421-hpd-irq-events-v3-4-44d2bf40dfc2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Small, focused patch: ```c if (extra_status == DRM_CONNECTOR_DP_IRQ_HPD) msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); ``` This correctly reuses the existing `EV_IRQ_HPD_INT` event path that already handles IRQ_HPD from native HPD sources. The early return for `internal_hpd` at the top of the function also covers this new code path. **Potential concern:** When both HPD connect and IRQ_HPD arrive simultaneously (initial connection with IRQ), both `EV_HPD_PLUG_INT` and `EV_IRQ_HPD_INT` are queued. The PLUG handler schedules async link training, so the IRQ_HPD handler may run before the link is fully trained. However, this is the same pattern as native HPD interrupt handling in `msm_dp_display_irq_handler()` where both interrupt bits can fire simultaneously, so the driver is already designed to handle this ordering. --- Generated by Claude Code Patch Reviewer