From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: do not import firmware commands into GSP command module
Date: Thu, 23 Apr 2026 07:34:43 +1000
Message-ID: <review-patch4-20260422-nova-unload-v3-4-1d2c81bd3ced@nvidia.com>
In-Reply-To: <20260422-nova-unload-v3-4-1d2c81bd3ced@nvidia.com>
References: <20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com> <20260422-nova-unload-v3-4-1d2c81bd3ced@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Looks good**

Replaces `use fw::commands::*` with `use fw::self` and qualifies all refere=
nces:

```rust
-            commands::*,
+            self,
```

Then e.g.:
```rust
-    type Command =3D GspSetSystemInfo;
+    type Command =3D fw::commands::GspSetSystemInfo;
```

And uses `Self::Command` where possible:
```rust
-        GspSetSystemInfo::init(self.pdev)
+        Self::Command::init(self.pdev)
```

The motivation is sound =E2=80=94 the commit message explains that glob imp=
orts obscure which layer a type belongs to and prevent same-named types at =
different layers (which patch 5 uses for `UnloadingGuestDriver`). Good prep=
aratory refactoring.

---
Generated by Claude Code Patch Reviewer