From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: Enable GPIOLIB for panels which uses functions from it Date: Thu, 23 Apr 2026 07:47:42 +1000 Message-ID: In-Reply-To: <20260422-panel-clean-up-kconfig-dep-v1-4-d825e9ffe911@ixit.cz> References: <20260422-panel-clean-up-kconfig-dep-v1-0-d825e9ffe911@ixit.cz> <20260422-panel-clean-up-kconfig-dep-v1-4-d825e9ffe911@ixit.cz> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** David Heidelberg **Status:** Looks good, minor nit. This patch adds `depends on GPIOLIB` to five panel drivers. I verified all five in the source tree: | Driver | Uses GPIOLIB functions | Confirmed | |--------|----------------------|-----------| | `panel-ebbg-ft8719.c` | `devm_gpiod_get`, `gpiod_set_value_cansleep` | Yes | | `panel-lg-sw43408.c` | `devm_gpiod_get`, `gpiod_set_value` | Yes | | `panel-novatek-nt36672a.c` | `devm_gpiod_get`, `gpiod_set_value` | Yes | | `panel-novatek-nt36672e.c` | `devm_gpiod_get`, `gpiod_set_value` | Yes | | `panel-visionox-rm69299.c` | `devm_gpiod_get`, `gpiod_set_value` | Yes | All five correctly need this dependency. Unlike patches 1-3, none of these had `select VIDEOMODE_HELPERS` to remove, so only the GPIOLIB addition is needed. **Minor grammar nit:** The subject says "which uses" but should be "which use" (panels is plural). Trivial. --- Generated by Claude Code Patch Reviewer