From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge-connector: Switch to .detect_ctx() for connector detection Date: Tue, 28 Apr 2026 15:25:20 +1000 Message-ID: In-Reply-To: <20260426-dw-hdmi-qp-scramb-v5-4-d778e70c317b@collabora.com> References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> <20260426-dw-hdmi-qp-scramb-v5-4-d778e70c317b@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch removes the old `.detect` callback from `drm_bridge_connector_funcs` and replaces it with a `.detect_ctx` helper hook: ```c static int drm_bridge_connector_detect_ctx(struct drm_connector *connector, struct drm_modeset_acquire_ctx *ctx, bool force) ``` The implementation correctly calls `drm_bridge_detect_ctx()` instead of `detect->funcs->detect()` directly, which routes through the proper fallback logic in patch 2. The error propagation (`if (ret < 0) return ret`) allows EDEADLK to bubble up to the DRM core's retry loop. **One observation:** With patch 4, the old `drm_bridge_connector_detect()` is completely removed. Any external caller that was using the `connector->funcs->detect` path will now get NULL. The DRM core's `drm_helper_probe_single_connector_modes()` prefers `.detect_ctx` over `.detect` when available, so this should be fine. The `.force` callback still exists and isn't changed, which is correct. **No issues found.** --- --- Generated by Claude Code Patch Reviewer