From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC Date: Tue, 28 Apr 2026 15:05:24 +1000 Message-ID: In-Reply-To: <20260427-gfx-clk-fixes-v2-4-797e54b3d464@oss.qualcomm.com> References: <20260427-gfx-clk-fixes-v2-0-797e54b3d464@oss.qualcomm.com> <20260427-gfx-clk-fixes-v2-4-797e54b3d464@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** Taniya Das ```c static int gx_clkctl_kaanapali_probe(struct platform_device *pdev) { - return qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); + int ret; + + ret = qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); + if (ret) + return ret; + + pm_runtime_disable(&pdev->dev); + + return ret; +} ``` The `return ret;` at the end is fine since `ret` is 0 at that point, but `return 0;` would be more idiomatic and clearer, since the error case already returned above. **Ordering concern:** This patch depends on patch 3. If `pm_runtime_put()` inside `qcom_cc_probe()` returns before the runtime suspend callback completes (the async case), then calling `pm_runtime_disable()` here could prevent the pending suspend from ever completing. Patch 3 ensures the put is synchronous, making this safe. The dependency should be noted in the commit message since these must be applied together. The approach of disabling runtime PM post-probe is a reasonable way to prevent devlink-propagated runtime PM transitions from reaching the gxclkctl device. --- --- Generated by Claude Code Patch Reviewer