From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Store IRQ register base iomem pointer in panthor_irq Date: Tue, 28 Apr 2026 14:28:32 +1000 Message-ID: In-Reply-To: <20260427155934.416502-5-karunika.choo@arm.com> References: <20260427155934.416502-1-karunika.choo@arm.com> <20260427155934.416502-5-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the key infrastructure patch. It adds an `iomem` field to `struct panthor_irq`, defines generic `INT_RAWSTAT`/`INT_CLEAR`/`INT_MASK`/`INT_STAT` offset macros at 0x0/0x4/0x8/0xc, and removes the `__reg_prefix` parameter from the `PANTHOR_IRQ_HANDLER` macro. Each IRQ request function now takes an `iomem` pointer. **Observation**: The generic macro names `INT_RAWSTAT`, `INT_CLEAR`, `INT_MASK`, `INT_STAT` defined in `panthor_device.h` are quite short and generic. While they're scoped to files that include this header (all panthor-internal), they could theoretically collide with other kernel-wide definitions. Consider prefixing them (e.g., `PANTHOR_INT_RAWSTAT`) for safety. This is a minor stylistic nit, not a blocker. **Note**: This patch is missing Reviewed-by/Acked-by tags from Boris, Liviu, and Steve, unlike patches 1-3. This may just be because it was reworked more significantly in v2/v3. --- Generated by Claude Code Patch Reviewer