From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mediatek: mtk_hdmi_ddc: Fix non-static global variable
Date: Tue, 05 May 2026 11:40:57 +1000 [thread overview]
Message-ID: <review-patch4-20260429-mediatek-drm-fix-sparse-warnings-v1-4-d95c4d118b83@collabora.com> (raw)
In-Reply-To: <20260429-mediatek-drm-fix-sparse-warnings-v1-4-d95c4d118b83@collabora.com>
Patch Review
```c
-struct platform_driver mtk_hdmi_ddc_driver = {
+static struct platform_driver mtk_hdmi_ddc_driver = {
```
Correct. `mtk_hdmi_ddc_driver` is only used at the definition and via `module_platform_driver()` in `mtk_hdmi_ddc.c`. The Fixes tag points to `c241118b6216` which switched to `module_platform_driver` — same pattern as patch 3, correct rationale.
**Reviewed-by worthy. No issues.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 1:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 9:58 [PATCH 0/4] drm/mediatek: fix sparse warnings Louis-Alexis Eyraud
2026-04-29 9:58 ` [PATCH 1/4] drm/mediatek: mtk_hdmi_ddc_v2: Fix non-static global variable Louis-Alexis Eyraud
2026-05-05 1:40 ` Claude review: " Claude Code Review Bot
2026-04-29 9:59 ` [PATCH 2/4] drm/mediatek: mtk_hdmi_v2: " Louis-Alexis Eyraud
2026-05-05 1:40 ` Claude review: " Claude Code Review Bot
2026-04-29 9:59 ` [PATCH 3/4] drm/mediatek: mtk_cec: " Louis-Alexis Eyraud
2026-05-05 1:40 ` Claude review: " Claude Code Review Bot
2026-04-29 9:59 ` [PATCH 4/4] drm/mediatek: mtk_hdmi_ddc: " Louis-Alexis Eyraud
2026-05-05 1:40 ` Claude Code Review Bot [this message]
2026-05-05 1:40 ` Claude review: drm/mediatek: fix sparse warnings Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260429-mediatek-drm-fix-sparse-warnings-v1-4-d95c4d118b83@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox