public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Remove unused operation context field
Date: Tue, 05 May 2026 11:14:08 +1000	[thread overview]
Message-ID: <review-patch4-20260429183253.66422-5-adrian.larumbe@collabora.com> (raw)
In-Reply-To: <20260429183253.66422-5-adrian.larumbe@collabora.com>

Patch Review

Removes `struct sg_table *sgt` from `panthor_vm_op_ctx.map`. The field was used in the current upstream tree at `panthor_gpuva_sm_step_map` and `panthor_gpuva_sm_step_remap`, so this patch relies on a prerequisite change (referenced by the `prerequisite-patch-id` in the cover letter) that migrated access to `bo->dmap.sgt`. This is fine given the stated base.

No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-05  1:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 18:32 [PATCH v10 0/6] Support sparse mappings in Panthor Adrián Larumbe
2026-04-29 18:32 ` [PATCH v10 1/6] drm/panthor: Expose GPU page sizes to UM Adrián Larumbe
2026-05-05  1:14   ` Claude review: " Claude Code Review Bot
2026-04-29 18:32 ` [PATCH v10 2/6] drm/panthor: Pass vm_bind_op to vm_prepare_map_op_ctx Adrián Larumbe
2026-05-05  1:14   ` Claude review: " Claude Code Review Bot
2026-04-29 18:32 ` [PATCH v10 3/6] drm/panthor: Delete spurious whitespace from uAPI header Adrián Larumbe
2026-05-05  1:14   ` Claude review: " Claude Code Review Bot
2026-04-29 18:32 ` [PATCH v10 4/6] drm/panthor: Remove unused operation context field Adrián Larumbe
2026-05-05  1:14   ` Claude Code Review Bot [this message]
2026-04-29 18:32 ` [PATCH v10 5/6] drm/panthor: Support sparse mappings Adrián Larumbe
2026-04-30  7:57   ` Boris Brezillon
2026-04-30  9:57     ` Boris Brezillon
2026-05-05  1:14   ` Claude review: " Claude Code Review Bot
2026-04-29 18:32 ` [PATCH v10 6/6] drm/panthor: Bump the driver version to 1.9 Adrián Larumbe
2026-05-05  1:14   ` Claude review: " Claude Code Review Bot
2026-05-05  1:14 ` Claude review: Support sparse mappings in Panthor Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-22 12:25 [PATCH v9 0/6] " Adrián Larumbe
2026-04-22 12:25 ` [PATCH v9 4/6] drm/panthor: Remove unused operation context field Adrián Larumbe
2026-04-22 21:41   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260429183253.66422-5-adrian.larumbe@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox