From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: Support MEDIA_BUS_FMT_FIXED Date: Tue, 05 May 2026 09:49:46 +1000 Message-ID: In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-4-d7e7f6bac77f@collabora.com> References: <20260501-synopsys-dw-dp-improvements-v2-0-d7e7f6bac77f@collabora.com> <20260501-synopsys-dw-dp-improvements-v2-4-d7e7f6bac77f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Treats `MEDIA_BUS_FMT_FIXED` as `MEDIA_BUS_FMT_RGB888_1X24` in `atomic_check`. This is needed because the aux-hpd-bridge at the end of the USB-C chain doesn't implement `atomic_get_output_bus_fmts()`. ```c + if (out_bus_format == MEDIA_BUS_FMT_FIXED) + out_bus_format = MEDIA_BUS_FMT_RGB888_1X24; ``` **Minor concern:** The fallback to RGB888 is reasonable but worth noting in a comment that this specifically handles the case of downstream bridges that don't negotiate bus formats (like aux-hpd-bridge). Other drivers (e.g., `dw-hdmi`) handle this similarly, so the pattern is established. --- Generated by Claude Code Patch Reviewer