From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: add Architecture::is_pre_hopper() helper
Date: Tue, 05 May 2026 09:10:01 +1000
Message-ID: <review-patch4-20260501205825.73614-5-joelagnelf@nvidia.com>
In-Reply-To: <20260501205825.73614-5-joelagnelf@nvidia.com>
References: <20260501205825.73614-1-joelagnelf@nvidia.com> <20260501205825.73614-5-joelagnelf@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

```rust
impl Architecture {
    pub(crate) fn is_pre_hopper(self) -> bool {
        matches!(self, Self::Turing | Self::Ampere | Self::Ada)
    }
}
```

Simple and correct. The current `Architecture` enum only has Turing, Ampere, and Ada variants, so this returns `true` for all current variants. When Hopper/Blackwell are added, this will automatically return `false` for them because of the `matches!` exhaustive listing (as opposed to a negation pattern like `!matches!(self, Self::Hopper | ...)`).

**Minor:** This is arguably premature since all supported architectures are pre-Hopper, but it's good forward-thinking and the code is trivial.

---
Generated by Claude Code Patch Reviewer