From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: vop2: Drop redundant zero-init in setup_layer_mixer() Date: Tue, 05 May 2026 08:08:46 +1000 Message-ID: In-Reply-To: <20260504-vop2-layer-cfg-tmout-v1-4-730226a7331e@collabora.com> References: <20260504-vop2-layer-cfg-tmout-v1-0-730226a7331e@collabora.com> <20260504-vop2-layer-cfg-tmout-v1-4-730226a7331e@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Trivially correct.** ```diff - u32 layer_sel = 0; + u32 layer_sel; ... - u32 atv_layer_sel = 0; + u32 atv_layer_sel; ``` Both variables are unconditionally assigned before use (`layer_sel = vop2->old_layer_sel` and `atv_layer_sel = vop2_readl(...)`) after patch 3. The zero-init is indeed dead. No issues. --- --- Generated by Claude Code Patch Reviewer