From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Replace spin_lock_irqsave() with spin_lock() Date: Sat, 16 May 2026 15:59:27 +1000 Message-ID: In-Reply-To: <20260510-v3d-sched-misc-fixes-v2-4-ca4aba343ef6@igalia.com> References: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> <20260510-v3d-sched-misc-fixes-v2-4-ca4aba343ef6@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review After patch 3 decoupled the fence lock, `queue_lock` is no longer shared with any IRQ handler, so plain `spin_lock()` suffices. The conversion to `scoped_guard(spinlock, ...)` is clean. One minor style observation: the `out_clean_job:` path in `v3d_bin_job_run` uses `scoped_guard` for a single assignment: ```c scoped_guard(spinlock, &queue->queue_lock) { queue->active_job = NULL; } ``` This is fine but slightly verbose for a one-liner. Not worth changing. No issues. --- Generated by Claude Code Patch Reviewer