From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: Inline resource lookup into bind() Date: Sat, 16 May 2026 16:14:39 +1000 Message-ID: In-Reply-To: <20260510183114.1248840-5-jonas@kwiboo.se> References: <20260510183114.1248840-1-jonas@kwiboo.se> <20260510183114.1248840-5-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean** Inlines `rockchip_hdmi_parse_dt()` into `dw_hdmi_rockchip_bind()`. The inlining is straightforward and faithful. The improvements are: 1. `hdmi->dev` is replaced with `dev` (consistent with patch 2). 2. Error messages for regulators now use `dev_err_probe()` with descriptive messages instead of silently returning error codes. 3. The braces around `if (ret) { return ...; }` are removed for single-statement bodies. The regulator error handling is slightly improved: the original code didn't log failures for `avdd-0v9` and `avdd-1v8` regulators, now they both use `dev_err_probe()`. No issues. --- --- Generated by Claude Code Patch Reviewer