From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/hisilicon/kirin: switch to of_drm_get_bridge_by_endpoint() Date: Sat, 16 May 2026 15:02:23 +1000 Message-ID: In-Reply-To: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-4-f61c9e498b3f@bootlin.com> References: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-0-f61c9e498b3f@bootlin.com> <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-4-f61c9e498b3f@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clever use of `__free(drm_bridge_put)` on the local bridge variable. The bridge is only needed to pass to `drm_bridge_attach()`, which (since v6.17) takes its own reference. So dropping the `of_drm_get_bridge_by_endpoint()` reference via the cleanup annotation when the variable goes out of scope is correct. ```c struct drm_bridge *bridge __free(drm_bridge_put) = NULL; ``` This is the cleanest conversion pattern for drivers that don't store the next_bridge pointer. No issues. --- Generated by Claude Code Patch Reviewer