From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe: Wire up dmem cgroup reclaim for VRAM manager Date: Sat, 16 May 2026 14:48:43 +1000 Message-ID: In-Reply-To: <20260511173008.36526-5-thomas.hellstrom@linux.intel.com> References: <20260511173008.36526-1-thomas.hellstrom@linux.intel.com> <20260511173008.36526-5-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Good.** Clean refactoring that moves `drmm_cgroup_register_region()` after `ttm_res= ource_manager_init()` and routes through the new `ttm_resource_manager_set_= dmem_region()` helper. The ordering change mirrors the fix in patch 1 for a= mdgpu =E2=80=94 registration now happens after `ttm_resource_manager_init()= ` but before `gpu_buddy_init()`. If registration fails, `ttm_resource_manag= er_init()` has already run, which is safe for teardown. One observation: unlike the amdgpu fix (patch 1), the xe registration is mo= ved to *before* `gpu_buddy_init()`, while in amdgpu (patch 1) it's moved to= *after* `gpu_buddy_init()`. This means if `drmm_cgroup_register_region()` = fails in xe, `gpu_buddy_init()` hasn't run yet. The xe teardown path should= handle this, but it's worth confirming that xe's cleanup is safe when budd= y isn't initialized. Given that this is the existing behavior (the original= code also had registration before buddy init), this should be fine. --- Generated by Claude Code Patch Reviewer