From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Extend the IRQ logic to allow fast/hard IRQ handlers
Date: Sat, 16 May 2026 13:32:45 +1000
Message-ID: <review-patch4-20260512-panthor-signal-from-irq-v2-4-95c614a739cb@collabora.com>
In-Reply-To: <20260512-panthor-signal-from-irq-v2-4-95c614a739cb@collabora.com>
References: <20260512-panthor-signal-from-irq-v2-0-95c614a739cb@collabora.com> <20260512-panthor-signal-from-irq-v2-4-95c614a739cb@collabora.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**R-b: Liviu Dudau, Steven Price**

Adds a `raw_handler` parameter to `panthor_irq_request()`:
```c
panthor_irq_request(... irqreturn_t (*raw_handler)(int, void *data),
                        irqreturn_t (*threaded_handler)(int, void *data))
```

When `threaded_handler` is NULL, uses `devm_request_irq()` (hard-only); otherwise uses `devm_request_threaded_irq()`. All existing callers pass `panthor_irq_default_raw_handler` and their threaded handler, so this is preparation only.

The logic is clean:
```c
if (!threaded_handler) {
    return devm_request_irq(ptdev->base.dev, irq, raw_handler,
                            IRQF_SHARED, full_name, pirq);
}
return devm_request_threaded_irq(ptdev->base.dev, irq, raw_handler, threaded_handler,
                                 IRQF_SHARED, full_name, pirq);
```

No concerns.

---

---
Generated by Claude Code Patch Reviewer