From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe: Wire up dmem cgroup reclaim for VRAM manager Date: Sat, 16 May 2026 14:04:00 +1000 Message-ID: In-Reply-To: <20260512082406.44470-5-thomas.hellstrom@linux.intel.com> References: <20260512082406.44470-1-thomas.hellstrom@linux.intel.com> <20260512082406.44470-5-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Good. Clean integration.** The patch reorders cgroup registration to after `ttm_resource_manager_init()` and uses the new helper: ```c + cg = drmm_cgroup_register_region(&xe->drm, name, size); + if (IS_ERR(cg)) + return PTR_ERR(cg); + ttm_resource_manager_set_dmem_region(man, cg); ``` The `drmm_` (managed) allocation ensures cleanup on failure paths. No issues. --- --- Generated by Claude Code Patch Reviewer