From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe: Handle PUNIT errors by requesting cold-reset recovery
Date: Sat, 16 May 2026 13:17:49 +1000
Message-ID: <review-patch4-20260512132614.1793083-11-mallesh.koujalagi@intel.com>
In-Reply-To: <20260512132614.1793083-11-mallesh.koujalagi@intel.com>
References: <20260512132614.1793083-7-mallesh.koujalagi@intel.com> <20260512132614.1793083-11-mallesh.koujalagi@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This is the core functional patch and is quite small.

```c
+static void punit_error_handler(struct xe_device *xe)
+{
+	xe_device_set_wedged_method(xe, DRM_WEDGE_RECOVERY_COLD_RESET);
+	xe_device_declare_wedged(xe);
+}
```

Clean and correct =E2=80=94 sets the recovery method, then declares the dev=
ice wedged, which triggers the uevent to userspace.

The call site change is also correct:
```c
-			/* TODO: Add PUNIT error handling */
+			punit_error_handler(xe);
 			return XE_RAS_RECOVERY_ACTION_DISCONNECT;
```

The function is properly `static` (as requested in v4 review feedback) and =
the `xe_` prefix is removed (v5 feedback).=20

**Note:** `xe_assert.h` and `xe_device_types.h` are added as includes but n=
either appears to be directly needed by the code added in this patch. The `=
xe_assert.h` include is unused. `xe_device_types.h` would already be pulled=
 in transitively through `xe_device.h`. These may be leftover from a previo=
us version.

```c
+#include "xe_assert.h"
+#include "xe_device_types.h"
```

---

---
Generated by Claude Code Patch Reviewer