From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/uapi: Add additional error components to xe drm_ras Date: Sat, 16 May 2026 12:54:50 +1000 Message-ID: In-Reply-To: <20260512191610.1817578-5-raag.jadav@intel.com> References: <20260512191610.1817578-1-raag.jadav@intel.com> <20260512191610.1817578-5-raag.jadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `DEVICE_MEMORY`, `PCIE`, and `FABRIC` error components to the uAPI enum. **Observation:** The enum starts at 1 (`DRM_XE_RAS_ERR_COMP_CORE_COMPUTE = 1`), meaning index 0 has no explicit mapping in `DRM_XE_RAS_ERROR_COMPONENT_NAMES`. This is pre-existing behavior, but it means the `error_components[]` array declared in `xe_drm_ras.c`: ```c static const char * const error_components[] = DRM_XE_RAS_ERROR_COMPONENT_NAMES; ``` will have a NULL at index 0 via zero-initialization. The code in `allocate_and_copy_counters` starts the loop at `DRM_XE_RAS_ERR_COMP_CORE_COMPUTE` which correctly skips index 0, so this works. Fine as-is. No issues with this patch. --- --- Generated by Claude Code Patch Reviewer