From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: qcom-uniphy: add more registers from display PHYs Date: Sat, 16 May 2026 11:32:10 +1000 Message-ID: In-Reply-To: <20260513-fd-hdmi-phy-v9-4-ca98c72f1f9f@oss.qualcomm.com> References: <20260513-fd-hdmi-phy-v9-0-ca98c72f1f9f@oss.qualcomm.com> <20260513-fd-hdmi-phy-v9-4-ca98c72f1f9f@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Extends `phy-qcom-uniphy.h` with additional register definitions imported from 28nm DSI and HDMI PHYs, including bitfield definitions using `GENMASK`/`BIT`. **Register naming**: Some registers use named defines (`UNIPHY_PLL_VCOLPF_CFG`), while others use generic numbered names (`UNIPHY_PLL_CTRL_42` through `UNIPHY_PLL_CTRL_48`, `UNIPHY_PLL_CTRL_54`). The numbered registers presumably don't have documented functional names, which is common for Qualcomm PHY registers. **R-b tag**: Has `Reviewed-by: Neil Armstrong`. No issues. --- Generated by Claude Code Patch Reviewer