From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: dp: handle the IRQ_HPD events reported by USB-C Date: Sat, 16 May 2026 11:25:51 +1000 Message-ID: In-Reply-To: <20260513-hpd-irq-events-v3-4-086857017f16@oss.qualcomm.com> References: <20260513-hpd-irq-events-v3-0-086857017f16@oss.qualcomm.com> <20260513-hpd-irq-events-v3-4-086857017f16@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```c + if (extra_status =3D=3D DRM_CONNECTOR_DP_IRQ_HPD) + msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); ``` This is the actual consumer =E2=80=94 a 3-line addition. The event fires th= e same `EV_IRQ_HPD_INT` as the hardware IRQ path, which is correct. **Potential issue: duplicate events when HPD + IRQ_HPD arrive together.** The code now does: ```c if (!msm_dp_display->link_ready && status =3D=3D connector_status_connecte= d) msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); else if (msm_dp_display->link_ready && status =3D=3D connector_status_disc= onnected) msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); if (extra_status =3D=3D DRM_CONNECTOR_DP_IRQ_HPD) msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 0); ``` When a USB-C DP connection is first established with an IRQ_HPD pending, bo= th `EV_HPD_PLUG_INT` and `EV_IRQ_HPD_INT` will be queued. This matches the = hardware behavior (the HW IRQ handler does the same thing =E2=80=94 plug an= d IRQ events are independently checked). So this looks correct. **No issues.** --- Generated by Claude Code Patch Reviewer