From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add documentation for warning backtrace suppression API Date: Sat, 16 May 2026 12:29:14 +1000 Message-ID: In-Reply-To: <20260513-kunit_add_support-v10-4-e379d206c8cd@redhat.com> References: <20260513-kunit_add_support-v10-0-e379d206c8cd@redhat.com> <20260513-kunit_add_support-v10-4-e379d206c8cd@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Good documentation** covering both API forms with clear examples. The RST= formatting looks correct. **One minor doc issue:** The documentation shows the direct API example che= cking the count *after* `kunit_end_suppress_warning()`: ```c w =3D kunit_start_suppress_warning(test); trigger_backtrace(); kunit_end_suppress_warning(test, w); KUNIT_EXPECT_EQ(test, kunit_suppressed_warning_count(w), 1); ``` This works because the `kunit_kzalloc`'d memory outlives the suppression de= activation (as confirmed by the multi_scope selftest). But it's worth notin= g this is a subtlety that could trip up readers =E2=80=94 the handle remain= s readable after `kunit_end_suppress_warning()` because the allocation is t= est-scoped. The doc might benefit from a brief note about this, but it's no= t a blocker. **Fix at the end:** The patch also fixes a missing newline at end of file (= `\ No newline at end of file` =E2=86=92 proper newline). Good housekeeping. --- Generated by Claude Code Patch Reviewer