From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add documentation for warning backtrace suppression API Date: Sat, 16 May 2026 10:56:14 +1000 Message-ID: In-Reply-To: <20260514-kunit_add_support-v11-4-b36a530a6d8f@redhat.com> References: <20260514-kunit_add_support-v11-0-b36a530a6d8f@redhat.com> <20260514-kunit_add_support-v11-4-b36a530a6d8f@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall: Clear and correct documentation.** The documentation covers both API forms with code examples and includes the= important note about checking warning counts inside the scoped block. **Minor: The doc shows `kunit_suppressed_warning_count(w)` used after `kuni= t_end_suppress_warning()`:** ```rst + w =3D kunit_start_suppress_warning(test); + trigger_backtrace(); + kunit_end_suppress_warning(test, w); + + KUNIT_EXPECT_EQ(test, kunit_suppressed_warning_count(w), 1); ``` This is valid because `w` remains allocated (via `kunit_kzalloc`) until tes= t exit. But it's worth being explicit in the documentation that `w` remains= readable after `kunit_end_suppress_warning` =E2=80=94 a reader might assum= e end-suppress frees the handle. The test code in patch 2 (`backtrace_suppr= ession_test_multi_scope`) relies on this same property, so it's an intentio= nal design choice. A one-line note in the docs like "The handle remains val= id for count queries after ``kunit_end_suppress_warning()``" would prevent = confusion. **Fixes missing newline at EOF:** ```diff - } \ No newline at end of file + } ``` Nice cleanup. **Summary:** This is a mature, well-reviewed series at v11. The core design= is sound, the test coverage is thorough, and the DRM usage patch is a good= practical demonstration. The issues identified are all minor style/documen= tation nits rather than correctness problems. From the DRM subsystem perspe= ctive, patch 3 is a clean improvement to the drm_rect tests. --- Generated by Claude Code Patch Reviewer